-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
espree v8 release process #475
Comments
I agree that it doesn't make sense to commit the changed |
It looks like we can handle a lot of this complexity by using a |
nzakas
added a commit
that referenced
this issue
Apr 16, 2021
mdjermanovic
pushed a commit
that referenced
this issue
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After we merge #469, we should update the release process to account for an additional build step.
The new build step (
npm run rollup
in #469) does two things:package.json
to updatelib/version.js
.dist/espree.cjs
.Current steps in generateRelease are:
npm test
.npm version
to updatepackage.json
. commit that change, and create git tag.But now we should have something like this:
npm version
to updatepackage.json
. commit that change, and create git tag.npm run rollup
.npm test
An additional question is whether or not should we commit
lib/version.js
. It might make sense to have a fixed"master"
(or"main"
) as the version string in the repo.Previous discussion: #469 (comment)
The text was updated successfully, but these errors were encountered: