Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update release-please #258

Merged
merged 2 commits into from
Jul 16, 2024
Merged

build: Update release-please #258

merged 2 commits into from
Jul 16, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 16, 2024

This upgrades release-please to v4 and switches to the official API.

I've also updated to use a manifest file.

Last, I switched to static values for the name and version in the JavaScript files. release-please can update the version number directly during a release, which removes the dependency on package.json. That's important for converting to ESM, which is my next step.

This was referenced Jul 16, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 847e8af into main Jul 16, 2024
16 checks passed
@mdjermanovic mdjermanovic deleted the release-please-update branch July 16, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants