Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @eslint/compat package #5

Merged
merged 5 commits into from
May 7, 2024
Merged

feat: @eslint/compat package #5

merged 5 commits into from
May 7, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Apr 29, 2024

This adds a @eslint/compat package with the following functions:

  • fixupRule() - used to wrap rules in a compatibility layer
  • fixupPluginRules() - used to wrap all rules in a plugin
  • fixupConfigRules() - used to wrap all rules in all plugins in a config array

View the README for more details.

closes #4

@aladdin-add aladdin-add self-requested a review April 30, 2024 02:56
@mdjermanovic
Copy link
Member

I prepared a PR to check this in action with eslint-plugin-react in the eslint.org repo: eslint/eslint.org#561

aladdin-add
aladdin-add previously approved these changes May 6, 2024
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@aladdin-add aladdin-add requested a review from mdjermanovic May 6, 2024 03:12
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just not sure if it's safe to merge until we resolve #8.

@mdjermanovic
Copy link
Member

Also, should we maybe do #3 (comment) in this package too?

@nzakas
Copy link
Member Author

nzakas commented May 7, 2024

It's safe to merge. The CI is doing some unneeded work but nothing consequential.

I'm going to go through and update all of the packages at in a separate PR.

@nzakas nzakas merged commit e765f07 into main May 7, 2024
9 checks passed
@nzakas nzakas deleted the backcompat-clean branch May 7, 2024 14:20
@github-actions github-actions bot mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Request: Backwards compatibility utility for rules
3 participants