-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Update Default Ignore Patterns #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
added
Initial Commenting
This RFC is in the initial feedback stage
breaking change
This RFC contains breaking changes
labels
Nov 28, 2019
aladdin-add
reviewed
Nov 28, 2019
platinumazure
approved these changes
Nov 28, 2019
kaicataldo
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! LGTM.
ilyavolodin
approved these changes
Dec 5, 2019
platinumazure
approved these changes
Dec 8, 2019
I have updated this proposal to stop ignoring |
mysticatea
added
Final Commenting
This RFC is in the final week of commenting
and removed
Initial Commenting
This RFC is in the initial feedback stage
labels
Dec 20, 2019
btmills
approved these changes
Dec 20, 2019
kaicataldo
approved these changes
Dec 20, 2019
mysticatea
added a commit
to eslint/eslint
that referenced
this pull request
Feb 8, 2020
mysticatea
added a commit
to eslint/eslint
that referenced
this pull request
Feb 8, 2020
btmills
pushed a commit
to eslint/eslint
that referenced
this pull request
Feb 14, 2020
montmanu
pushed a commit
to montmanu/eslint
that referenced
this pull request
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
This RFC contains breaking changes
Final Commenting
This RFC is in the final week of commenting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This proposal changes the default ignore patterns to include the
node_modules
of subdirectories and to exclude.eslintrc.js
.Related Issues
.
by default eslint#10341 - do not ignore files started with.
by default