-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessing cwd
from formatters
#57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a logical addition.
cwd
from formatterscwd
from formatters
@mysticatea it has been 21 days and this already has two approvals. You can choose to move this into final commenting if you want. |
Thank you. I moved this to final commenting. |
@mdjermanovic just wanted to double check that you don't have any comments on this? We're ready to merge if you're all set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks like we have consensus, so merging. |
* chore: Make fixture test assertions more explicit I need to add another formatter to this directory that will shift all of these results, so I'm making these assertions more explicit so it's obvious why a seemingly-unrelated change will cause these to fail. * Update: pass cwd to formatters (refs eslint/rfcs#57) * chore: Update tests using formatter fixture dir * update docs * Fix link to ESLint API docs Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Remove unused docs.category rule meta field Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Fix typo in docs note Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> Co-authored-by: Brandon Mills <mills.brandont@gmail.com> Co-authored-by: Brandon Mills <btmills@users.noreply.github.com> Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Summary
This RFC lets formatters can access
cwd
in order to make relative paths or do something like.Related Issues