Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing cwd from formatters #57

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Accessing cwd from formatters #57

merged 2 commits into from
Jul 30, 2020

Conversation

mysticatea
Copy link
Member

Rendered RFC

Summary

This RFC lets formatters can access cwd in order to make relative paths or do something like.

Related Issues

@mysticatea mysticatea added the Initial Commenting This RFC is in the initial feedback stage label Jun 5, 2020
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a logical addition.

@nzakas nzakas changed the title New: Accessing cwd from formatters Accessing cwd from formatters Jun 29, 2020
@nzakas
Copy link
Member

nzakas commented Jul 14, 2020

@mysticatea it has been 21 days and this already has two approvals. You can choose to move this into final commenting if you want.

@mysticatea mysticatea added Final Commenting This RFC is in the final week of commenting and removed Initial Commenting This RFC is in the initial feedback stage labels Jul 16, 2020
@mysticatea
Copy link
Member Author

Thank you. I moved this to final commenting.

@nzakas
Copy link
Member

nzakas commented Jul 28, 2020

@mdjermanovic just wanted to double check that you don't have any comments on this? We're ready to merge if you're all set.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nzakas
Copy link
Member

nzakas commented Jul 30, 2020

Looks like we have consensus, so merging.

@nzakas nzakas merged commit 0b5742d into master Jul 30, 2020
@nzakas nzakas deleted the cwd-in-formatters branch July 30, 2020 00:29
btmills pushed a commit to eslint/eslint that referenced this pull request Nov 21, 2021
btmills pushed a commit to eslint/eslint that referenced this pull request Nov 27, 2021
mdjermanovic added a commit to eslint/eslint that referenced this pull request Nov 30, 2021
* chore: Make fixture test assertions more explicit

I need to add another formatter to this directory that will shift all of
these results, so I'm making these assertions more explicit so it's
obvious why a seemingly-unrelated change will cause these to fail.

* Update: pass cwd to formatters (refs eslint/rfcs#57)

* chore: Update tests using formatter fixture dir

* update docs

* Fix link to ESLint API docs

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

* Remove unused docs.category rule meta field

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

* Fix typo in docs note

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Co-authored-by: Brandon Mills <mills.brandont@gmail.com>
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Commenting This RFC is in the final week of commenting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants