Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: automate generation of meeting transcripts #186

Merged
merged 9 commits into from
Jul 3, 2020

Conversation

kaicataldo
Copy link
Member

Hopefully this works! GitHub Action development always feels like trial and error to me...

@kaicataldo kaicataldo force-pushed the automate-meeting-transcripts branch from 3642a41 to 029a16d Compare July 3, 2020 00:03
@kaicataldo kaicataldo force-pushed the automate-meeting-transcripts branch from 029a16d to a200c53 Compare July 3, 2020 00:07
@kaicataldo
Copy link
Member Author

CI ran, at least!

Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change to the output file path and optional suggestions around date parsing. Then let’s see if it works 🤞 I’ve used https://github.com/nektos/act to test-run workflows locally, so you might be able to give that a try if you want.

scripts/generate-transcript.js Outdated Show resolved Hide resolved
scripts/generate-transcript.js Outdated Show resolved Hide resolved
kaicataldo and others added 2 commits July 3, 2020 12:31
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
@kaicataldo
Copy link
Member Author

Updated - thanks for the review!

Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let’s give it a shot! 🤞

@kaicataldo kaicataldo merged commit b233987 into master Jul 3, 2020
@kaicataldo kaicataldo deleted the automate-meeting-transcripts branch July 3, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants