Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add 2024-11-28 meeting notes #549

Merged
merged 1 commit into from
Dec 1, 2024
Merged

docs: Add 2024-11-28 meeting notes #549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions notes/2024/2024-11-28.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# 2024-11-28 ESLint TSC Meeting Notes

## Transcript

[`2024-11-28-transcript.md`](2024-11-28-transcript.md)

## Attending

- Milos Djermanovic (@mdjermanovic) - TSC
- Francesco Trotta (@fasttime) - TSC

@nzakas moderated, and @sam3k took notes.

## Topics

### Statuses

* **@mdjermanovic:**
* Made a follow-up refactor PR that adds missing properties in meta.defaultOptions of core rules and simplifies getting options in several rules.
* Added new `ignoreComputedKeys` option in the sort-keys rule and enabled eslint-plugin-eslint-plugin in `@eslint/*` language plugins.
* **@fasttime:**
* Been adding type tests for the language plugins and triaging several issues.
* Also working on preparing an RFC for multithread linting.


### RFC Duty Schedule

* November 25: @fasttime
* December 2: @nzakas
* December 9: @mdjermanovic
* December 16: @fasttime


### [perf: Fix caching in config loaders](https://github.com/eslint/eslint/pull/19042)

We had an action item from the meeting before the previous one, to compare performances starting from ESLint `v9.11.1`. @mdjermanovic did some performance comparisons from ESLint `v9.11.1` to `v9.15.0`, on Node.js `v22.11.0`. Some observations:

* Per the "Multiple Individual Files" test made for that PR, the config caching problem introduced in `v9.12.0` has been fixed in `v9.14.0`.
* Interestingly, on the other hand, all of our standard performance tests, which are Loading, Single File (one big file), and Multi Files (450 files matched by a glob) show notable performance improvements in `v9.12.0`. This was unexpected, but welcome 🙂
* Surprisingly, the effects of Node.js compile cache, enabled in ESLint `v9.13.0`, aren't noticeable in test results.
* There seems to be a small but noticeable degradation in Loading and Multiple Individual Files tests in `v9.15.0`

**Action Items:**

- @mdjermanovic will repeat the tests to double check and the will post the results in the same issue.


### Scheduled release for November 29th, 2024

**Action Items:**

- @fasttime will release:
- `eslint`
- `@eslint/js`