This repository has been archived by the owner on Jan 19, 2019. It is now read-only.
Docs: add options to README #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kaicataldo
reviewed
Oct 27, 2018
There was a problem hiding this comment.
Thanks for contributing! The underlying parser this package uses was recently separated out into its own package (called typescript-estree), and that's where the option is actually used.
Do you mind signing the CLA so we can merge this?
|
I signed the CLA. I also updated the README. How does that look? |
|
Ah, looks like the commit message doesn't match our guidelines. I'll update it, but for posterity, more information can be found here. |
|
Thanks for contributing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are these options inherited from somewhere? If so, then maybe we should just mention that, and only list ones that are specific to this parser.