Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated to use bootstrap accordion class for Additional Information section (per recommendation by @DiegoPino & @aksm), and includes @karomabiles recommendation to make the ID for the Related Item section consistent with the webform.
- Loading branch information
1 parent
f53f18b
commit ca99ef9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -280,20 +280,20 @@ <h2>Language</h2> | |
| data.related_item_note|length > 0 | ||
| %} | ||
| <h2>Additional Information</h2> | ||
| <div class="accordion" id="additionalInformation"> | ||
| {% if data.note|length > 0 or | ||
| data.note_publishinginfo|length > 0 | ||
| %} | ||
| <div class="accordion-item"> | ||
| <div class="accordion-header" id="Notes"> | ||
| <h5 class="mb-0"> | ||
| <button class="accordion-button" data-bs-toggle="collapse" data-bs-target="#collapseOne" data-toggle="collapse" data-target="#collapseOne" aria-expanded="true" aria-controls="collapseOne"> | ||
| Note(s) | ||
| </button> | ||
| </h5> | ||
| </div> | ||
| <div id="collapseOne" class="collapse show" aria-labelledby="headingOne" data-bs-parent="#accordion" data-parent="#accordion"> | ||
| <div class="accordion-body"> | ||
| {% if data.note|length > 0 %} | ||
| <h6>General note: </h6> | ||
| {% if data.note is iterable %} | ||
|
|
@@ -322,16 +322,16 @@ <h6>Publishing Info Note: </h6> | |
| data.physical_description_extent|length > 0 or | ||
| data.data.physical_description_note_condition|length > 0 | ||
| %} | ||
| <div class="accordian-item"> | ||
| <div class="accordion-header" id="PhysicalDescription"> | ||
| <h5 class="mb-0"> | ||
| <button class="accordion-button" data-bs-toggle="collapse" data-bs-target="#collapseTwo" data-toggle="collapse" data-target="#collapseTwo" aria-expanded="false" aria-controls="collapseTwo"> | ||
| Physical Description | ||
| </button> | ||
| </h5> | ||
| </div> | ||
| <div id="collapseTwo" class="collapse" aria-labelledby="headingTwo" data-bs-parent="#accordion" data-parent="#accordion"> | ||
| <div class="accordion-body"> | ||
| {% if data.physical_location|length > 0 %} | ||
| <h6>Physical location: </h6><p>{{ data.physical_location }}</p> | ||
| {% endif %} | ||
|
|
@@ -346,16 +346,16 @@ <h6>Condition Note: </h6><p>{{ data.physical_description_note_condition }}</p> | |
| </div> | ||
| {% endif %} | ||
| {% if data.subjects_local|length > 0 or data.subjects_local_names|length > 0 %} | ||
| <div class="accordian-item"> | ||
| <div class="accordian-header" id="LocalSubjectsNames"> | ||
| <h5 class="mb-0"> | ||
| <button class="accordion-button" data-bs-toggle="collapse" data-bs-target="#collapseThree" data-toggle="collapse" data-target="#collapseThree" aria-expanded="false" aria-controls="collapseThree"> | ||
| Local Subjects & Names | ||
| </button> | ||
| </h5> | ||
| </div> | ||
| <div id="collapseThree" class="collapse" aria-labelledby="headingThree" data-parent="#accordion" data-bs-parent="#accordion"> | ||
| <div class="accordian-body"> | ||
| {% if data.subjects_local %} | ||
| <ul> | ||
| {% if data.subjects_local is iterable %} | ||
|
|
@@ -389,20 +389,20 @@ <h5 class="mb-0"> | |
| data.related_item_host_location_url|length > 0 or | ||
| data.related_item_host_type_of_resource|length > 0 or | ||
| data.related_item_note|length > 0 %} | ||
| <div class="accordian-item"> | ||
| <div class="accordion-header" id="RelatedItem"> | ||
| <h5 class="mb-0"> | ||
| <button class="accordion-button" data-bs-toggle="collapse" data-toggle="collapse" data-bs-target="#collapseFour" data-target="#collapseFour" aria-expanded="false" aria-controls="collapseFour"> | ||
| Related Item Notes | ||
| </button> | ||
| </h5> | ||
| </div> | ||
| <div id="collapseFour" class="collapse" aria-labelledby="headingFour" data-bs-parent="#accordion" data-parent="#accordion"> | ||
| <div class="accordian-body"> | ||
| {% if data.related_item_host_display_label|length > 0 and data.related_item_host_title_info_title|length > 0 %} | ||
| <h6>{{ data.related_item_host_display_label }}: </h6><p>{{ data.related_item_host_title_info_title }}</p> | ||
| {% endif %} | ||
| {% if data.related_item_host_display_label|length < 0 and data.related_item_host_title_info_title|length > 0 %} | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. 
DiegoPino
via email
Member
|
||
| <h6>Related Item Host Title Info: </h6><p>{{ data.related_item_host_title_info_title }}</p> | ||
| {% endif %} | ||
| {% if data.related_item_host_local_identifier|length > 0 %} | ||
|
|
||
Should this have stayed
is empty? Did it accidentally get reverted from f53f18b?