Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-183: Patch Facets/Views Blocks and Update composer.json #184

Merged
merged 3 commits into from
May 16, 2022
Merged

ISSUE-183: Patch Facets/Views Blocks and Update composer.json #184

merged 3 commits into from
May 16, 2022

Conversation

DiegoPino
Copy link
Member

See #183 and esmero/archipelago-deployment-live#50

This adds:

  • Modded Patch to allow Facet/Sorts/Filter preservation on Exposed Views Forms (blocks)
  • Removes some dependencies
  • Adds Plugin allowance and Configure our packages to be fetched from source

This is not the final/cleaned up composer.json and the lock will be matched once we go into release mode

@DiegoPino DiegoPino requested a review from aksm May 16, 2022 14:01
@DiegoPino DiegoPino self-assigned this May 16, 2022
@DiegoPino DiegoPino added enhancement New feature or request Drupal9 Drupal9 is the new Drupal8 which was the new Drupal7 wich was the... Composer.json Keep your Libraries fresh Release Duties We are all duty here, heavy duty patch Means we are going to patch this thing Deployment Strategies What every vendor would love to Copy and pasta labels May 16, 2022
@DiegoPino DiegoPino added this to the 1.0.0 milestone May 16, 2022
aksm
aksm reviewed May 16, 2022
View reviewed changes
Copy link
Contributor

@aksm aksm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting the following error when I deploy:

Could not apply patch! Skipping. The error was: Cannot apply patch patches/3032353-25-archipelago-05162022.patch

composer.json Outdated Show resolved Hide resolved
@DiegoPino
Copy link
Member Author

Getting the following error when I deploy:

Could not apply patch! Skipping. The error was: Cannot apply patch patches/3032353-25-archipelago-05162022.patch

Hi, you testing with Drupal 9.3?

@DiegoPino
Copy link
Member Author

DiegoPino commented May 16, 2022 •
edited
Loading

This was tested (the patch) with drupal/core:9.3.11. This pull does not include yet an updated composer.lock bc there is more work to do on dependencies and versions for 1.0.0

That said, maybe I got the patch wrong?

@aksm
Copy link
Contributor

aksm commented May 16, 2022

This was tested (the patch) with drupal/core:9.3.11. This pull does not include yet an updated composer.lock bc there is more work to do on dependencies and versions for 1.0.0

That said, maybe I got the patch wrong?

My fault! I registered but didn't fully heed your warning about the lock file.

@DiegoPino DiegoPino merged commit 2296881 into 1.0.0 May 16, 2022
@DiegoPino
Copy link
Member Author

Thanks @aksm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aksm aksm aksm approved these changes

Assignees

@DiegoPino DiegoPino

Labels
Composer.json Keep your Libraries fresh Deployment Strategies What every vendor would love to Copy and pasta Drupal9 Drupal9 is the new Drupal8 which was the new Drupal7 wich was the... enhancement New feature or request patch Means we are going to patch this thing Release Duties We are all duty here, heavy duty
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DiegoPino @aksm