Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-193: PHP debug docker container needs update #194

Merged
merged 1 commit into from
Aug 10, 2022
Merged

ISSUE-193: PHP debug docker container needs update #194

merged 1 commit into from
Aug 10, 2022

Conversation

aksm
Copy link
Contributor

@aksm aksm commented Aug 10, 2022

Resolves #193

@aksm aksm added this to the 1.0.0 milestone Aug 10, 2022
@aksm aksm requested a review from DiegoPino August 10, 2022 14:02
@aksm aksm self-assigned this Aug 10, 2022
@DiegoPino
Copy link
Member

@aksm thanks. Yes! Also, did you ever finish testing your own PHP8 image? The ones referenced here are still the ones I built without intl. I'm ok for today with this but goal would be to be sure 100% those new images do all the rest. Thanks

@DiegoPino DiegoPino merged commit 1d4f957 into esmero:1.0.0 Aug 10, 2022
@aksm
Copy link
Contributor Author

aksm commented Aug 10, 2022

@aksm thanks. Yes! Also, did you ever finish testing your own PHP8 image? The ones referenced here are still the ones I built without intl. I'm ok for today with this but goal would be to be sure 100% those new images do all the rest. Thanks

@DiegoPino Last I checked it was working, but will test again with everything updated. Does the debug container need to have it as well?

@DiegoPino
Copy link
Member

Yes the debug container too, once the other one is tested. Maybe to avoid overlapping/having a rollback you can tag the new ones as 1.1.0?

@DiegoPino
Copy link
Member

The debug container builds in not time since it extends the base one with a few extras

@aksm aksm deleted the ISSUE-193 branch October 20, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoPino DiegoPino Awaiting requested review from DiegoPino

Assignees

@aksm aksm

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aksm @DiegoPino