ISSUE-334: Provide a manual Content-Type for the plain Binary Controller #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way we can also allow non symfony default Mime Types and make AMI also happy
DiegoPino
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #334. Symfony provides its own implementation inside the
::prepareoption but it is limited to a smaller/different/subset of mime types and will not work for model/obj etc leading to text. Better to use the already calculated one like we do in the ranged controller section/streamed controller section already. Tested and this does not affect any other implementation and plays well with AMI tooThis also solves #333 (since I was here)