Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-338: Custom error handler needs to filter out unhelpful errors/deprecations #347

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

aksm
Copy link
Contributor

@aksm aksm commented Jul 27, 2023

Resolves #338. Tested with E_USER_DEPRECATED via trigger_error(), which doesn't interfere with preview functionality while logging (when error level is set to debug). Also displays the error from #274 to user, along with other user errors and warnings.

@aksm aksm self-assigned this Jul 27, 2023
@aksm aksm marked this pull request as ready for review July 28, 2023 19:23
@aksm aksm requested a review from DiegoPino July 28, 2023 19:23
Copy link
Member

@DiegoPino DiegoPino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aksm small/tiny change. Can you please update the * Throw ErrorException for all errors passed from trigger_error(). It now only throws errors on USER warning and USER error

Copy link
Member

@DiegoPino DiegoPino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. Thanks

@DiegoPino DiegoPino added this to the 1.1.1 milestone Aug 1, 2023
@DiegoPino DiegoPino added enhancement New feature or request Twig Twig template processing metadata Meta(l) data Custom Entities labels Aug 1, 2023
@DiegoPino DiegoPino merged commit 26ac3ad into esmero:1.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Custom Entities enhancement New feature or request metadata Meta(l) data Twig Twig template processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants