ISSUE-368: edtf_2_iso_date #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still, good to test with our plugins/iiif tiles and clustering
edtf_2_iso_date returns always an array. [] always. ok?
DiegoPino
added
metadata
|
Note: this pull contains also #366. Just bc whoever gets merged first wins (and if that gets merged first this one will be 1:1/no need to rebase) |
@alliomeria this here fixes the case where an legacy OSD viewer fails to detect (bc code was updated/settings were behind) the lack of IIIF driven manifests and triggers Warning: Undefined variable $manifests in Drupal\format_strawberryfield\Plugin\Field\FieldFormatter\StrawberryBaseIIIFManifestFormatter->fetchIIIF() (line 381 of modules/contrib/format_strawberryfield/src/Plugin/Field/FieldFormatter/StrawberryBaseIIIFManifestFormatter.php).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? see #368
edtf_2_iso_datewhich is a filter returns always an array. Either empty if we could not parse it, wrong data, etc. a single 'Y-d-m' value or two 'Y-d-m' if a range/uncertainty with 2 possible dates.