ISSUE-374: Macro issue, update to Drupal 10, PHP 8.1 #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires some changes on SBF too and more work. - Still not processing the fragments from a "target" field back to a Canvas.
Issue 248 patch - Update JMESPaths by @digitaldogsbody!
Small improvement to `IIIF_V3_JMESPATH`
No nulls anymore allowed.. yeah PHP, nice
…esser in Symfony. Cool folks. Cool
DiegoPino
added
Release duties
Working Group's 💜
@giancarlobi dear friend. Sorry for taking years on bringing your code into the main branches. Just know you are appreciated and admired. Added you as co-author bc it is your code, in only added a setting so this can be disabled (does not work well if the manifest is bringing multiple PDFs bc the page ID does not work - yet - but i'm working on that :) Co-Authored-By: Giancarlo <4232178+giancarlobi@users.noreply.github.com>
jquery_ui_slider 2.0 is basically empty? can not be enabled, but it works. weiiiird
Also, both OSD and Mirador can now override settings directly via an ADO {"ap:viewerhints": { "strawberry_mirador_formatter": {"somesetting":"somevalue"}}
@alliomeria you might like this ...
Looking at this, we need some work here. Like why a selector if we have a single citation? This should be an option...
in the same order the affect the output rendering on the offcanvas and also by priority
This will add the search term in the same way IABOOKreader uses it (as a fragment with /search/theterm to the URL
Also, had to fix the TwigTemplateConstraintValidator bc changes .... Symfony!!
Of a template, once validated it should call from cache. Added an extra "invalidate" post Save just in case we end with stuck caches of caches.
@alliomeria ready for a compose require?? and a drush update? Last thing this Friday!
With some having if inside and some not. By keeping track of the "level" we are in, and decreasing deepness on endfors found we can do this in a more reliable way without having to keep track if found or not as a single dimensional "reality" @alliomeria this fixes the AMI template that you have (which is SUPER complex). More testing Monday maybe?
ISSUE-248: backend (metadata display) driven Search for OCR + WIP. Merging against Open pull against 1.3.0 to get in sync/keep editing
…s Done Matching requerst/route/routematches so <current> renders in the context of the original Manifest (and thus our backend Canvas IDs match the front end) instead of the called Search endpoint URL was a thing.. Such a thing! TODO: add width and height (canvas level) so we can target the right place for the response.Also, get the Item level offset in case i need to do 101 Coordinate/local/relative to canvas math(z) More tomorrow @alliomeria
(well i need to say this to myself)
Ok this does the IIIF trick. It reuses a multi "hit" text and splits it in pieces only leaving the before and after corresponding to the actual hit. Basically a single OCR Highlight might produce multiple boxes. @alliomeria almost done!
But i need more validation...way more - TODO: paging - Clean up ?q so it has a max, is properly escape, etc - Add the ignored arguments - Process Content Search v2 too - Add the second mode (simple) - Cache the heavy processing - Create the ADO level (human) annotation strawvberry runnner processor - Create the Config Form
If the IIIF Manifest is embargoed? We should still add a try/catch around the rendering just in case
@alliomeria just another git pull. Thanks!
Content Search API for 1.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #374
Lots of mime guesser stuff + JS jQuery/once (that is a pain). Small "ensure" we don't trim NULLs or Explode NULLs (basically don't explode/die also don't trim your beard if you don't have any - not my case -)