Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement per issue 1311 - use same socket for both Bidir directions #1321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidBar-On
Copy link
Contributor

Suggested enhancement to allow bidir to use the same port in both directions. The approach is using the same socket for both directions. A new optional argument for the --bidir option is added for that: --bidir=1 (the "1" is for one socket/port).

@swg0101
Copy link

swg0101 commented Apr 15, 2022

Note that this doesn't apply on 3.11, but it does on master:

patching file src/iperf.h
patching file src/iperf_api.c
Hunk #1 succeeded at 730 (offset -18 lines).
Hunk #2 succeeded at 1004 (offset -23 lines).
Hunk #3 succeeded at 1265 (offset -23 lines).
Hunk #4 succeeded at 2101 (offset -23 lines).
Hunk #5 succeeded at 2218 (offset -23 lines).
Hunk #6 succeeded at 2751 (offset -23 lines).
Hunk #7 succeeded at 3015 (offset -23 lines).
patching file src/iperf_api.h
Hunk #1 succeeded at 318 (offset -4 lines).
patching file src/iperf_client_api.c
Hunk #3 FAILED at 71.
Hunk #4 succeeded at 109 (offset -6 lines).
Hunk #5 succeeded at 285 (offset -6 lines).
1 out of 5 hunks FAILED -- saving rejects to file src/iperf_client_api.c.rej
patching file src/iperf_locale.c
patching file src/iperf_server_api.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants