Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
master
or3.1-STABLE
) to which this pull request applies:master
Issues fixed (if any):
When the file doesnt exists (--rsa-public-key-path), execution results in Segmentation fault #1471
Brief description of code changes (suitable for use as a commit message):
Suggested fix crash when public/private key file does not exist - may not be th full fix as the issue didn't happen on my PC. However, the output of
BIO_new_file()
was not checked, which could lead to such crash inPEM_read_bio_xxxxKey()
(depending on the library implementation).In addition moved reading the private key file before prompting for the password, so the user will not have to enter password before the failure because file does not exist.