Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the congestion protocol on the server between tests #1812

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

hwti
Copy link
Contributor

@hwti hwti commented Dec 14, 2024

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:
    master

  • Issues fixed (if any):

  • Brief description of code changes (suitable for use as a commit message):
    Reset the congestion protocol between tests. Otherwise, the server keeps the last congestion protocol asked by a client (-C option), applying it to the following clients not asking for a specific protocol.

Otherwise, the server keeps the last congestion protocol asked by a
client (-C option), applying it to the following clients not asking for
a specific protocol.
@bmah888
Copy link
Contributor

bmah888 commented Jan 6, 2025

Thanks for the bug report and PR! I've been able to reproduce the problem.

@bmah888 bmah888 self-assigned this Jan 10, 2025
@bmah888 bmah888 added the bug label Jan 10, 2025
Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it solves the problem. Thanks for the PR!

@bmah888
Copy link
Contributor

bmah888 commented Jan 10, 2025

Tested this by using the -verbose option to both iperf3 client and server, with various -C arguments.

@bmah888 bmah888 merged commit 352ef1b into esnet:master Jan 10, 2025
3 checks passed
@hwti hwti deleted the reset-congestion-protocol branch January 14, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants