Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -B with some SCTP tests, which is part of #678 #715

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

jijianwen
Copy link
Contributor

Got the following error when running server side with -B option:

Server side:
./iperf3 -s -B <server_ipv4_address>
-----------------------------------------------------------
Server listening on 5201
-----------------------------------------------------------
iperf3: error - unable to start stream listener: Bad file descriptor
-----------------------------------------------------------

Client side:
./iperf3 -c <server_ipv4_address> --sctp
iperf3: error - unable to start stream listener: No such file or directory

Similar fix as below for TCP:
commit eb1cfe5
Author: Bruce A. Mah bmah@es.net
Date: Fri Aug 1 16:24:14 2014 -0700

    Another iteration on issue #193, fixes -B with some TCP tests.

Signed-off-by: Jianwen Ji jijianwen@gmail.com

PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":

You are under no obligation whatsoever to provide any bug fixes, patches, or
upgrades to the features, functionality or performance of the source code
("Enhancements") to anyone; however, if you choose to make your Enhancements
available either publicly, or directly to Lawrence Berkeley National
Laboratory, without imposing a separate written license agreement for such
Enhancements, then you hereby grant the following license: a non-exclusive,
royalty-free perpetual license to install, use, modify, prepare derivative
works, incorporate into other computer software, distribute, and sublicense
such enhancements or derivative works thereof, in binary and source code form.

The complete iperf3 license is available in the LICENSE file in the
top directory of the iperf3 source tree.

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:

  • Issues fixed (if any):

  • Brief description of code changes (suitable for use as a commit message):

Got the following error when running server side with -B option:

Server side:
    ./iperf3 -s -B <server_ipv4_address>
    -----------------------------------------------------------
    Server listening on 5201
    -----------------------------------------------------------
    iperf3: error - unable to start stream listener: Bad file descriptor
    -----------------------------------------------------------

Client side:
    ./iperf3 -c <server_ipv4_address> --sctp
    iperf3: error - unable to start stream listener: No such file or directory

Similar fix as below for TCP:
    commit eb1cfe5
    Author: Bruce A. Mah <bmah@es.net>
    Date:   Fri Aug 1 16:24:14 2014 -0700

        Another iteration on issue esnet#193, fixes -B with some TCP tests.

Signed-off-by: Jianwen Ji <jijianwen@gmail.com>
@jijianwen
Copy link
Contributor Author

jijianwen commented Mar 13, 2018

@bmah888 , Please help review this patch

@bmah888
Copy link
Contributor

bmah888 commented Mar 16, 2018

Thanks for taking the time to send this pull request. This is an acknowledgment of having seen it...I'm hoping to find some free cycles to work on iperf3 sometime soon.

Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seems to fix the problem. Thanks for the pull request!

@bmah888 bmah888 self-assigned this Mar 23, 2018
@bmah888 bmah888 added the bug label Mar 23, 2018
@bmah888 bmah888 added this to the 3.6 milestone Mar 23, 2018
@bmah888 bmah888 merged commit 3e58489 into esnet:master Mar 23, 2018
palmerc pushed a commit to palmerc/iperf that referenced this pull request Jul 8, 2018
Got the following error when running server side with -B option:

Server side:
    ./iperf3 -s -B <server_ipv4_address>
    -----------------------------------------------------------
    Server listening on 5201
    -----------------------------------------------------------
    iperf3: error - unable to start stream listener: Bad file descriptor
    -----------------------------------------------------------

Client side:
    ./iperf3 -c <server_ipv4_address> --sctp
    iperf3: error - unable to start stream listener: No such file or directory

Similar fix as below for TCP:
    commit eb1cfe5
    Author: Bruce A. Mah <bmah@es.net>
    Date:   Fri Aug 1 16:24:14 2014 -0700

        Another iteration on issue esnet#193, fixes -B with some TCP tests.

Signed-off-by: Jianwen Ji <jijianwen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants