This repository has been archived by the owner on May 23, 2024. It is now read-only.
Improve backtrace #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
I had the fixing of the address in the architecture specific code which worked fine but for Xtensa subtracting 3 from the address when storing it in the result triggered some mis-compilation apparently and in release mode it never generated a backtrace
I definitely ran into this before! Thanks for fixing!
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we reported the return-address which often resulted in getting the wrong source location in espflash which made the backtrace look weird and wrong. On Xtensa it wasn't that bad but on RISCV it was often wrong
Now we try to report the address of the call instead which makes the backtrace much better
(Sidenote: originally, I had the fixing of the address in the architecture specific code which worked fine but for Xtensa subtracting 3 from the address when storing it in the result triggered some mis-compilation apparently and in release mode it never generated a backtrace)