Implement Peripheral

esp-rs · Oct 18, 2024 · 399cf60 · 399cf60
1 parent 888b955
commit 399cf60
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/esp-hal/src/i2c.rs b/esp-hal/src/i2c.rs
@@ -501,16 +501,17 @@ where
     ) -> Self {
         crate::into_ref!(i2c, sda, scl);
 
-        PeripheralClockControl::reset(i2c.peripheral());
-        PeripheralClockControl::enable(i2c.peripheral());
-
         let i2c = I2c {
             i2c,
             phantom: PhantomData,
             frequency,
             timeout,
         };
 
+        PeripheralClockControl::reset(i2c.i2c.peripheral());
+        PeripheralClockControl::enable(i2c.i2c.peripheral());
+
+        // TODO: implement with_pins et. al.
         // avoid SCL/SDA going low during configuration
         scl.set_output_high(true, crate::private::Internal);
         sda.set_output_high(true, crate::private::Internal);