Skip to content

Commit

Permalink
Review changes
Browse files Browse the repository at this point in the history
Co-authored-by: Dominic Fischer <14130965+Dominaezzz@users.noreply.github.com>
  • Loading branch information
bugadani and Dominaezzz committed Oct 24, 2024
1 parent 0d8e7d8 commit c039ea8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion esp-hal/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Removed the pin type parameters from `parl_io::{TxOneBit, TxTwoBits, TxFourBits, TxEightBits, TxSixteenBits}` (#2388)
- Removed the pin type parameters from `parl_io::{RxOneBit, RxTwoBits, RxFourBits, RxEightBits, RxSixteenBits}` (#2388)
- Removed the pin type parameters from `lcd_cam::lcd::i8080::{TxEightBits, TxSixteenBits}` (#2388)
- Removed the pin type parameters from `lcd_cam::lcd::cam::{RxEightBits, RxSixteenBits}` (#2388)
- Removed the pin type parameters from `lcd_cam::cam::{RxEightBits, RxSixteenBits}` (#2388)

## [0.21.1]

Expand Down
4 changes: 1 addition & 3 deletions esp-hal/src/gpio/interconnect.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,12 @@ use crate::{
///
/// Peripheral drivers are encouraged to accept types that implement this and
/// [`PeripheralOutput`] as arguments instead of pin types.
#[doc(hidden)]
pub trait PeripheralInput: Into<InputConnection> + 'static {}

/// A signal that can be connected to a peripheral input and/or output.
///
/// Peripheral drivers are encouraged to accept types that implement this and
/// [`PeripheralInput`] as arguments instead of pin types.
#[doc(hidden)]
pub trait PeripheralOutput: Into<OutputConnection> + 'static {}

impl<P: InputPin> PeripheralInput for P {}
Expand Down Expand Up @@ -282,7 +280,7 @@ impl OutputSignal {
impl OutputSignal {
/// Connect the pin to a peripheral input signal.
///
/// Since there can only be one input signal connected to a peripheral at a
/// Since there can only be one signal connected to a peripheral input at a
/// time, this function will disconnect any previously connected input
/// signals.
fn connect_input_to_peripheral(&mut self, signal: gpio::InputSignal, _: private::Internal) {
Expand Down

0 comments on commit c039ea8

Please sign in to comment.