Support for psram on ESP32-PICO-V3-02 (revision v3.0) #1155
Comments
|
That's great! In general, we don't have a lot of requirements - we just have https://github.com/esp-rs/esp-hal/blob/main/CONTRIBUTING.md . Just file a PR and make sure to document what changed in CHANGELOG.md and someone will review it |
|
Hi @maxwen , did you manage to create a PR to get the code upstream? I just got an M5STICKC PLUS2 and it comes with PICO V3-02 and I'd like to try esp-rs on it. Could I use your reference commit? Have you found anything that behaves strange or needs tweaking or would need testing with anything? Thanks! |
sebosp
added a commit
to sebosp/esp-hal
that referenced
this issue
Apr 11, 2024
maxwen/esp-hal@6ba9b84 closes esp-rs#1155 Signed-off-by: Seb Ospina <kraige@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 22, 2024
* Adapting maxwen branch to v0.16.1 maxwen/esp-hal@6ba9b84 closes #1155 Signed-off-by: Seb Ospina <kraige@gmail.com> * ESP32-PICO-V3-02 init Signed-off-by: Seb Ospina <kraige@gmail.com> * rustfmt * Update CHANGELOG.md --------- Signed-off-by: Seb Ospina <kraige@gmail.com> Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Like using in Adafruit ESP32 Feather V2
I managed to make it working and testing so far showed no problems (still needs more testing though)
maxwen@6ba9b84
Right now this is just a quick and hacky implementation for my personal projects but I would be happy to clean it up
to follow your requirements for contributing. So I was wondering how to get things started.
The text was updated successfully, but these errors were encountered: