Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't enable async interrupts without async feature #1042

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Don't enable async interrupts without async feature #1042

merged 3 commits into from
Dec 19, 2023

Conversation

JurajSadel
Copy link
Contributor

@JurajSadel JurajSadel commented Dec 19, 2023 •
edited
Loading

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

closes #1041

@JurajSadel
Copy link
Contributor Author

Not related to this PR but I noticed we are missing some examples in our CI checks, for example, embassy_rmt_XX for RISCV targets. I will add them in a separate PR.

bjoernQ
bjoernQ approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you!

jessebraham
jessebraham approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham added this pull request to the merge queue Dec 19, 2023
Merged via the queue into esp-rs:main with commit 244c747 Dec 19, 2023
17 checks passed
Volkalex28 pushed a commit to Volkalex28/esp-hal that referenced this pull request Feb 6, 2024
@JurajSadel @Volkalex28
Don't enable async interrupts without async feature (esp-rs#1042)
c92df45 
* only enable interrupts if the async feature is present

* remove warnings and fmt

* changelog
@JurajSadel JurajSadel deleted the async-interrupts branch April 10, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using embassy examples w/o using async feature enables unhandled interrupts
3 participants
@JurajSadel @jessebraham @bjoernQ