Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement embedded_hal 1 pwm traits for ledc channel #1097

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

Remmirad
Copy link
Contributor

@Remmirad Remmirad commented Jan 19, 2024

Implements embedded_hal_1::pwm::SetDutyCycle for ledc::channel::Channel.

Tries to handle max duty cycle resolution differences between embedded_hal and esp32 (16, 20).

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable). (Would only be a rough copy of the ledc example?)
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code. (embedded_hal provides it)

@bjoernQ
Copy link
Contributor

bjoernQ commented Jan 22, 2024

Looks good to me but probably you need to double check CHANGELOG.md since there was a release in the meantime and the entry would probably not go into the unreleased section

@Remmirad Remmirad force-pushed the ledc_pwm_embedded_hal_1 branch from 3e67040 to bdfde35 Compare January 22, 2024 17:55
@Remmirad
Copy link
Contributor Author

Thanks for the remark. I rebased and put the change in the new unreleased section.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham added this pull request to the merge queue Jan 23, 2024
Merged via the queue into esp-rs:main with commit 76b5d77 Jan 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants