Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for timer value to be latched for esp32(c3/c6) #1178

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

ju6ge
Copy link
Contributor

@ju6ge ju6ge commented Feb 18, 2024

While using the timer on the esp32c3 i noticed that reading timer values was not working as expected. Seems the c3 and also c6 need to wait for the value to be correctly latched before reading the current timer value.

Here the relevant section in the TRM Section 11.3

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

@ju6ge ju6ge force-pushed the fix/timer-now-c3-c6 branch 2 times, most recently from 80a2970 to ef18996 Compare February 18, 2024 12:02
@ju6ge ju6ge force-pushed the fix/timer-now-c3-c6 branch from ef18996 to e820473 Compare February 18, 2024 12:05
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are more chips where this is needed but we can merge this and I will create an issue to apply this to more chips

@bjoernQ bjoernQ added this pull request to the merge queue Feb 19, 2024
Merged via the queue into esp-rs:main with commit b0bb0ab Feb 19, 2024
17 checks passed
@ju6ge ju6ge deleted the fix/timer-now-c3-c6 branch February 21, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants