-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update esp-hal/README #1228
Update esp-hal/README #1228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some quite nitpicky comments (sorry!) that I think we should address.
Overall it looks okay but I think we should expand on the features of the HAL, for example, should mention that we support async. I would also link to the the LP hal for LP support core support. I would also link to esp-wifi for wifi/ble support.
Given the README will be on crates.io (forgot about that first) maybe we should "borrow" some ideas and get inspiration from other HALs - e.g. https://crates.io/crates/embassy-stm32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nitpicks, thanks for taking care of this!
Regarding format, might be worth to try following the style guide that we wrote for the book: https://github.com/esp-rs/book/blob/main/rust-doc-style-guide.md. I've just used the vale config created from those rules and here is the output:
Most of the things are not relevant Id say |
Oh that's really nice! Do you know if we can run this in CI 👀. Maybe that's not worth the effort though. |
That was the idea, at least for the books/trainings, but so far it's not possible as the repo with vale rules is under GitLab and its closed-source. I've had some conversations about how to use it on CI, but I haven't heard any update regarding this in the last months, I'll try to get an update. |
I think prose linting our READMEs in CI is probably barbaric overkill, but can we move this to a discussion or something instead please, so the conversation doesn't disappear with this PR. |
Would be good if the usage paragraph would link to the (not merged yet) README for the examples ( #1237 ) - not sure if we then want or should have the command to run examples duplicated or not |
…e and add quickstart
Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>
Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>
Co-authored-by: Scott Mabin <scott@mabez.dev>
* Mostly rewrite `esp-hal/README.md` (oops :) ) * Fix a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had my way with this file now, so LGTM 😁
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errors
orwarnings
.cargo fmt
was run.CHANGELOG.md
in the proper section.Nice to have
Removes chip-specific references, briefly describes
esp-hal
tree, and adds quickstart.closes #1224