Add new embassy features for esp32s2 and other systimers. Enable embassy tick rate features by default #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssy tick rate features by default
MabezDev
force-pushed
the
enable-embassy-tickrates
branch
from
89c06d3 to
cd835b1
Compare
jessebraham
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Thanks for taking care of this, I think this should be an acceptable stopgap solution until we're able to tackle #1035 at which point we can revisit this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1239
Ended up not being completely horrible. I did take another look at the trms to see if there was any way to make both types output the same freq, but sadly it doesn't seem possible.