Create virtual peripherals for CPU control and radio clocks #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
changed the title
bjoernQ
reviewed
Apr 12, 2024
bjoernQ
reviewed
Apr 12, 2024
|
This LGTM, just need to use peripheral ref on the constructors like @bjoernQ said. |
|
Sorry forgot on Friday, will get that updated shortly! |
bjoernQ
reviewed
Apr 16, 2024
| pub struct CpuControl { | ||
| _cpu_control: crate::system::CpuControl, | ||
| pub struct CpuControl<'d> { | ||
| _cpu_control: PeripheralRef<'d, CPU_CTRL>, |
There was a problem hiding this comment.
I think we don't really need to store it if we don't have any use for it
bjoernQ
approved these changes
Apr 16, 2024
JurajSadel
reviewed
Apr 16, 2024
|
I'm having second thoughts on merging this before the release, maybe we should wait so that we can tackle the remaining bits of the |
jessebraham
force-pushed
the
refactor/system
branch
from
dbc0f98 to
7e78ce6
Compare
|
This should be fine to merge now, I think. |
jessebraham
force-pushed
the
refactor/system
branch
from
7e78ce6 to
a27eeff
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first step towards #1401, the changes get a little more involved from here on out so I figured I'd just split things up to keep it easy to review.
In short, I've created virtual
CPU_CTRLandRADIO_CLKperipherals, rather than manually defining the structs like we used to do when splitting.Happy to hear any feedback regarding peripheral names, I think these are reasonable though.