-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the SystemExt
trait and rename SystemParts
to SystemControl
#1495
Conversation
9357cd2
to
f69c651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care of this!
f69c651
to
47d6f97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
It seems this PR is the source of some frustration I had today, and I believe it comes down to there being no version bump:
My conclusion is that without the version bump, cargo does not know that it needs to refresh/update |
Further work towards #1401, finally removes the
SystemExt
trait entirely. TheSystemParts
struct has been renamed toSystemControl
(open to suggestions on naming here, but this seemed to fit with the other structs we've defined) which now has a constructor which takes theSYSTEM
peripheral.@MabezDev I'm still not 100% sure if we're on the same page regarding these changes or not, so would appreciate your feedback here. As usual happy to make any changes.
While I was in here I also noticed that the
SoftwareInterrupt
struct had no fields, so converted it to a unit struct instead.I also moved some
CHANGELOG.md
entries which were mistakenly added to the wrong release in another PR.