GPIO Refactoring #1542
Merged
GPIO Refactoring #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bjoernQ
commented
May 7, 2024
bjoernQ
commented
May 7, 2024
| @@ -42,7 +42,7 @@ pub struct SystemTimer<'d, DM: crate::Mode> { | |||
| pub alarm0: Alarm<Target, DM, 0>, | |||
| pub alarm1: Alarm<Target, DM, 1>, | |||
| pub alarm2: Alarm<Target, DM, 2>, | |||
| _phantom: &'d PhantomData<()>, | |||
| _phantom: PhantomData<&'d ()>, | |||
There was a problem hiding this comment.
unrelated to this PR but makes this ZST
bjoernQ
commented
May 7, 2024
| // Begin configuring the TWAI peripheral. The peripheral is in a reset like | ||
| // state that prevents transmission but allows configuration. | ||
| let mut can_config = twai::TwaiConfiguration::new( | ||
| let mut can_config = twai::TwaiConfiguration::new_no_transceiver( |
There was a problem hiding this comment.
don't really like it but probably not too bad
bjoernQ
commented
May 7, 2024
| } | ||
|
|
||
| /// Trait implemented by pins which can be used as outputs | ||
| pub trait OutputPin: Pin { | ||
| /// Configure open-drain mode | ||
| fn set_to_open_drain_output(&mut self) -> &mut Self; | ||
| fn set_to_open_drain_output(&mut self, _: private::Internal); |
There was a problem hiding this comment.
returning &mut Self makes it inconvenient for delegation - since it's an internal API I don't think this is a problem
JurajSadel
reviewed
May 10, 2024
bjoernQ
force-pushed
the
refactor-gpio
branch
2 times, most recently
from
739e382 to
29b5230
Compare
JurajSadel
approved these changes
May 14, 2024
MabezDev
reviewed
May 14, 2024
MabezDev
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
This is a huge PR with dramatic changes. I also have some ideas for a follow-up PR but I guess this is more than enough to review already.
Most probably this will need a migration-guide for the next release but probably best to wait for the review (and probably for a potential follow-up PR)
Testing
All examples and tests work