Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async-serial-usb-jtag #1561

Merged
merged 2 commits into from
May 17, 2024
Merged

Fix async-serial-usb-jtag #1561

merged 2 commits into from
May 17, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented May 17, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

This is a fix for #1560

Testing

See #1560

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! LGTM.

@MabezDev MabezDev added this pull request to the merge queue May 17, 2024
Merged via the queue into esp-rs:main with commit 9f1cf17 May 17, 2024
22 checks passed
@bjoernQ bjoernQ deleted the fix-usb-serial-jtag branch November 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants