-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32-S2: Add SPI Slave support #1562
Conversation
Given that the example is almost a test, could we add some test cases? I think we will need some hardware changes as we'll need more pins wired up. |
This will be fun. See #1332 (comment) to have some reference when choosing the new pins so we can avoid having too many |
Maybe we can do this in another PR if it will be a pain, but it seems like something we can test in the future at least which would be nice! |
2720aa2
to
c2fa4ac
Compare
Let's add this in another PR, Tomas is on leave this week and we need to buy cables as well, in a meantime I can try to figure out the pins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks
c2fa4ac
to
3c9d7e5
Compare
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Adds SPI Slave for ESP32S2 and removes ESP32 parts from it.
Testing
Tested with
spi_slave_dma
example.Builds on top of #1514 but removed all ESP32-related changes from the driver. After discussion with @bjoernQ, we agreed it makes sense to add just S2 and remove ESP32 parts, we've burnt so much time on that and the thing doesn't work.