Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32-S2: Add SPI Slave support #1562

Merged
merged 6 commits into from
May 22, 2024

Conversation

JurajSadel
Copy link
Contributor

@JurajSadel JurajSadel commented May 17, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Adds SPI Slave for ESP32S2 and removes ESP32 parts from it.

Testing

Tested with spi_slave_dma example.

Builds on top of #1514 but removed all ESP32-related changes from the driver. After discussion with @bjoernQ, we agreed it makes sense to add just S2 and remove ESP32 parts, we've burnt so much time on that and the thing doesn't work.

This was referenced May 17, 2024
esp-hal/src/spi/slave.rs Show resolved Hide resolved
esp-hal/src/spi/slave.rs Outdated Show resolved Hide resolved
esp-hal/src/spi/slave.rs Outdated Show resolved Hide resolved
@MabezDev
Copy link
Member

Given that the example is almost a test, could we add some test cases? I think we will need some hardware changes as we'll need more pins wired up.

@SergioGasquez
Copy link
Member

Given that the example is almost a test, could we add some test cases? I think we will need some hardware changes as we'll need more pins wired up.

This will be fun. See #1332 (comment) to have some reference when choosing the new pins so we can avoid having too many cfgs arround

@MabezDev
Copy link
Member

This will be fun. See #1332 (comment) to have some reference when choosing the new pins so we can avoid having too many cfgs arround

Maybe we can do this in another PR if it will be a pain, but it seems like something we can test in the future at least which would be nice!

@JurajSadel JurajSadel force-pushed the esp32-esp32s2-spi-slave branch from 2720aa2 to c2fa4ac Compare May 21, 2024 14:24
@JurajSadel
Copy link
Contributor Author

This will be fun. See #1332 (comment) to have some reference when choosing the new pins so we can avoid having too many cfgs arround

Maybe we can do this in another PR if it will be a pain, but it seems like something we can test in the future at least which would be nice!

Let's add this in another PR, Tomas is on leave this week and we need to buy cables as well, in a meantime I can try to figure out the pins.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks

@bjoernQ bjoernQ added this pull request to the merge queue May 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 22, 2024
@JurajSadel JurajSadel force-pushed the esp32-esp32s2-spi-slave branch from c2fa4ac to 3c9d7e5 Compare May 22, 2024 13:10
@JurajSadel JurajSadel enabled auto-merge May 22, 2024 13:11
@JurajSadel JurajSadel added this pull request to the merge queue May 22, 2024
Merged via the queue into esp-rs:main with commit 76ed67a May 22, 2024
22 checks passed
@JurajSadel JurajSadel deleted the esp32-esp32s2-spi-slave branch May 23, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants