-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract embassy support into esp-hal-embassy
package
#1595
Extract embassy support into esp-hal-embassy
package
#1595
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
c88e4a8
to
ef7dede
Compare
@@ -504,7 +519,7 @@ fn lint_packages(workspace: &Path, _args: LintPackagesArgs) -> Result<()> { | |||
&[ | |||
"-Zbuild-std=core", | |||
"--target=riscv32imc-unknown-none-elf", | |||
"--features=esp32c3,wifi-default,ble,esp-now,async,embassy-net", | |||
"--features=esp32c3,wifi-default,ble,esp-now,async,embassy-net,esp-hal-embassy/time-timg0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this was necessary, probably I'm missing something?
Still need to finish documentation and review further, but rebased my branch and updated the |
ef7dede
to
46c3d3e
Compare
![Crates.io](https://img.shields.io/crates/l/esp-hal-embassy?labelColor=1C2C2E&style=flat-square) | ||
[![Matrix](https://img.shields.io/matrix/esp-rs:matrix.org?label=join%20matrix&labelColor=1C2C2E&color=BEC5C9&logo=matrix&style=flat-square)](https://matrix.to/#/#esp-rs:matrix.org) | ||
|
||
[Embassy] support for `esp-hal`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README.md
could definitely use some expansion, however I'm not really sure what should be included here and what belongs in documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems I have problem using the systimer-time-driver and running e.g. the embassy-hello-world code. Using timg0-driver works |
Looking into it |
Seems to be broken on |
689ffcc
to
c39a587
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c39a587
to
586a04b
Compare
Okay I cannot for the life of me figure out why the "correct" fix for this isn't working. I've debugged my implementation, everything appears to be correct, but it's just plain not working. So, I give up on that. I've included a hacky "fix", which is pretty objectively bad, but also it's not like we're not doing this all over the code base already. Ideally I'd like to fix this, however I also would like to get this merged and released so I can stop thinking about timers for awhile. If anybody else wants to take a swing at a better fix please feel free, or if you have any suggestions I can try them out. |
…utor` module public
f8fb5f9
to
4ca40ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Nice to see this split out, and a bunch of features removed from esp-hal.
The last piece of this puzzle will be docs I think, but we already have to figure that out for esp-wifi, so we can do that later.
Let's try this again 😁
I've opened this PR as a draft for the time being as it still needs a
README.md
file for the new package, and I still need to finish documenting the new package as well. However, in the meantime, we can at least review the code changes. I will get this wrapped up on Monday.I've done some very minimal testing and things seem to be in order, however more thorough testing is still required.
Closes #1035