-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flex/AnyFlex pin drivers #1659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent, thanks for working on this! Very nice PR.
LGTM!
I have a few ideas for improving the docs here and also on the "landing page" to help new users to have a smooth(er) start. But well - not in this PR (and we should generally wait for the doc-test PR to land before shuffling around docs I guess) But it's definitely already much easier than the |
I think the docs topic touches #742 |
I opened #1660 to track the module level doc improvements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
This adds a Flex/AnyFlex pin driver to fix #740
Testing
The GPIO HIL-test exercises the new driver. Doesn't seem to deserve a dedicated example