Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check DMA descriptors and buffers addresses #1670

Merged

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jun 11, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Fixes #954

This adds a check for the descriptors and buffers which need to be located in RAM (see #954 (comment))

Some (two) of our currently supported chips can support DMA buffers to be located in extmem but there are a lot of requirements to make that work - if we ever consider it's worth to support it, we can change that but for now this fixes an existing pitfall

Testing

I added a test-case for this. With this, now the lcd_i8080 example will fail at runtime - that's a problem of the example, not this check.

If we think we should fix the example here, I can do - but I can't test it.

@bjoernQ bjoernQ marked this pull request as ready for review June 11, 2024 12:05
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you. I appreciate the test cases too!

LGTM!

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JurajSadel JurajSadel added this pull request to the merge queue Jun 11, 2024
Merged via the queue into esp-rs:main with commit 1122df1 Jun 11, 2024
29 checks passed
@bjoernQ bjoernQ deleted the check-dma-descriptors-and-buffers-memory-region branch November 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMA-driven SPI silently fails to transfer if data is in DCache
3 participants