Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose optional HSYNC input in LCD_CAM #1707

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

Dominaezzz
Copy link
Collaborator

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

There's an optional HSYNC input signal that wasn't exposed, this PR exposes it.

Testing

Ran the modified example

@jessebraham
Copy link
Member

These changes look fine to me, however I still don't have access to a devkit to test these changes so I've asked @playfulFence to take a look when he gets a chance. Appreciate your patience!

@playfulFence
Copy link
Contributor

Hello @Dominaezzz!
Sorry for it taking so long!
I've tested your updated version of a driver. And here are some results.
Honestly, I'm not really familiar with this driver, but from the first look both changes and the result looks nice
Let me know if this is an expected output. Also please make sure to rebase your branch

Before fix:
image

After fix:
image

@Dominaezzz
Copy link
Collaborator Author

Yes that's what I'm expecting. FF, D8, FF, E0 is how valid JPEGs start.

I'll rebase

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@jessebraham jessebraham added this pull request to the merge queue Jul 2, 2024
Merged via the queue into esp-rs:main with commit fc826ca Jul 2, 2024
30 checks passed
@Dominaezzz Dominaezzz deleted the fix_cam branch July 3, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants