Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve xtensa interrupt latency #1735

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jun 28, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

This applies basically the same changes I already did for RISC-V in #1679

Numbers measured on ESP32-S3:

Before: 18.66 / 13.68
After: 13.20 / 7.79

Testing

Used same setup as in the RISC-V PR

@bjoernQ bjoernQ marked this pull request as ready for review June 28, 2024 10:57
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment that you're free to ignore, otherwise LGTM!

esp-hal/src/interrupt/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JurajSadel JurajSadel added this pull request to the merge queue Jul 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2024
@SergioGasquez SergioGasquez added this pull request to the merge queue Jul 3, 2024
Merged via the queue into esp-rs:main with commit 4f9dc96 Jul 3, 2024
30 checks passed
@bugadani bugadani mentioned this pull request Aug 21, 2024
5 tasks
@bjoernQ bjoernQ deleted the improve-xtensa-interrupt-latency branch November 26, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants