-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support dma chunk sizes other than 4092 #1758
Conversation
@bjoernQ In my previous PR I fixed a HIL test issue by Insuring that the test dropped the |
- `.div_ceil()` - return errors for bad chunk size and buffer sizes in Mem2Mem constructors - correct 0 chunk size check in descripter macros
Sounds good to me! Better to not hope for defaults being always set |
Added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
This PR will allow dma "chunk sizes" other than the default 4092.
Description
This is needed to support DMA to/from psram on the esp32s3 where it requires that the
size
andaddress pointer
fields in eachDmaDescriptor
are required to be "block" aligned where the block alignment is selectable from the set of 16, 32, or 64 bytes. (support for DMA to/from psram will be a seperate PR)dma_buffer
type macros were refactored to remove code duplication and to add_chunk_size
variants.Testing
tests were added for all of the
dma_
macrosadded an additional mem2mem test using a different CHUNK_SIZE