-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpio: DummyPin + hub75_i8080 example #1769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test the example but the dummy pin is useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I also don't have a way of testing the example, I will ask, if someone from the team could give it a try. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I like the dummy pin, but I think the example is probably not required. We won't be able to test it and it will likely bit rot over time. Could you remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
DummyPin for when you don't want/have a real Pin.
Description
This PR adds DummyPin. Useful in cases where you have to supply a pin but it wont really be used, like
esp_hal::lcd_cam::lcd::i8080::TxSixteenBits
but you only want 14 bits. The included example does exactly this driving a HUB75 LED Matrx display using the lcd_cam peripheral.Testing
Tested on esp32s3 with the new example.