Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp-wifi: Check no password given for AuthMethod::None #1806

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jul 16, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Fixes #1621

Testing

Using one of the wifi examples in the repo - change the auth_method to None and see it returns an error now

bjoernQ added 2 commits July 16, 2024 13:27

Verified

This commit was signed with the committer’s verified signature.
addaleax Anna Henningsen
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something, but what would happen if we just didn't copy the password from the config when AuthMethod::None 🤔

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Jul 16, 2024

I might be missing something, but what would happen if we just didn't copy the password from the config when AuthMethod::None 🤔

That's an option but IMHO the user would still supply wrong arguments - we would just silently "fix" it for them. I'd say if we wouldn't already potentially return an error that would be a better option but since the user already should check for an error I think I like being explicit here more

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, LGTM thanks!

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the improvement.

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JurajSadel JurajSadel added this pull request to the merge queue Jul 16, 2024
Merged via the queue into esp-rs:main with commit 3729923 Jul 16, 2024
31 checks passed
@bjoernQ bjoernQ deleted the esp-wifi/check-auth-method branch November 26, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esp32c6 uses only password while config AuthMethod:None
4 participants