Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp-hal: Add HIL test for embassy timer and executor #1886

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

JurajSadel
Copy link
Contributor

@JurajSadel JurajSadel commented Jul 31, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Adds initial HIL tests for embassy timer (Timg and systimer as OneShotTimer and PeriodicTimer) and executors (both Thread and Interrupt one) and different variations.

Testing

All tests should pass, changes to the underlying code should cause some tests to fail. Tested locally on C3, C6 and S3.

Closes #1639

@JurajSadel JurajSadel added the skip-changelog No changelog modification needed label Jul 31, 2024
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! - Great we have a start here

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this!

hil-test/tests/embassy_timers_executors.rs Show resolved Hide resolved
@SergioGasquez SergioGasquez added this pull request to the merge queue Aug 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 5, 2024
@jessebraham jessebraham added this pull request to the merge queue Aug 5, 2024
Merged via the queue into esp-rs:main with commit c5ea0e9 Aug 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HIL test(s) to verify all Embassy executors and time drivers
4 participants