-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DMA starving SPI #2152
Fix DMA starving SPI #2152
Conversation
53f7373
to
1c56efe
Compare
ef8d448
to
308a979
Compare
I tried to run I (125) boot: Disabling RNG early entropy source...
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9] .. [73, 74, 75, 76, 77, 78, 79, 7a, 7b, 0]
[1, 0, 0, 0, 1, 1, 1, 1, 1, 1] .. [1, 1, 1, 1, 1, 1, 1, 1, 1, 1]
[2, 0, 0, 0, 1, 1, 1, 1, 1, 1] .. [1, 1, 1, 1, 1, 1, 1, 1, 1, 1]
[3, 0, 0, 0, 1, 1, 1, 1, 1, 1] .. [1, 1, 1, 1, 1, 1, 1, 1, 1, 1] |
Oh wow you're right. Previously even my first iteration was bad so I assumed that fixing the test was enough, but alas, not. |
Will it still work if you skip the first call to |
You mean line 2234? Apparently it does, yes. Funnily enough we had a |
Yeah that one. Nice! At least that matches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - great we have this tested now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #2151
Thank you, Dominic