Slight general cleanup, enable dma-macros test, allow using virtual mem2mem channel on c2 #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
changed the title
24 tasks
bugadani
changed the title
bjoernQ
reviewed
Sep 20, 2024
MabezDev
approved these changes
Sep 20, 2024
| embassy_time_driver::time_driver_impl!(static DRIVER: EmbassyTimer = EmbassyTimer { | ||
| alarms: Mutex::new([ALARM_STATE_NONE; MAX_SUPPORTED_ALARM_COUNT]), | ||
| alarms: Mutex::new([const { AlarmState::new() }; MAX_SUPPORTED_ALARM_COUNT]), |
There was a problem hiding this comment.
New toys with the 1.79 msrv :)
| #[allow(clippy::declare_interior_mutable_const)] | ||
| const INIT: AtomicWaker = AtomicWaker::new(); | ||
| static WAKERS: [AtomicWaker; NUM_I2C] = [INIT; NUM_I2C]; | ||
| const NUM_I2C: usize = 1 + cfg!(i2c1) as usize; |
There was a problem hiding this comment.
This is a nice trick, we should do this in more places.
Dominaezzz
reviewed
Sep 20, 2024
| }, | ||
| _ => panic!("Only SPI2 and SPI3 supported"), | ||
| } | ||
| dport |
There was a problem hiding this comment.
This init_channel function can be removed and this code can be moved to either configure/configure_for_async or set_peripheral.
There was a problem hiding this comment.
I didn't want to modify this code too much lest your PR will probably conflict, but let's see :)
jessebraham
approved these changes
Sep 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Failure looks like a network error if anything; rebased & retrying merge |
Yeah I've seen this happen a few times before, has always succeeded in a subsequent run in my experience at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dma_macrosfor ESP32 and S2