Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TWAI on ESP32 #2207

Merged
merged 17 commits into from
Sep 23, 2024
Merged

Fix TWAI on ESP32 #2207

merged 17 commits into from
Sep 23, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Sep 20, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

A few issues here and there

cc #324

Testing

Ran HIL test locally on both 32 and S2.

@MabezDev
Copy link
Member

LGTM, thanks for tackling this!

I noticed you added self test example to the issue checklist, do you see much value in doing that? We already have an example, and HIL tests that exercise the self test mode.

@bugadani
Copy link
Contributor Author

I noticed you added self test example to the issue checklist, do you see much value in doing that?

What do you mean I added it? 🤔

image

@MabezDev
Copy link
Member

MabezDev commented Sep 23, 2024

Ah sorry this diff made it look like you added it and I didn't go back and check the other edits, not sure why my diff is different 🤷

image

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham added this pull request to the merge queue Sep 23, 2024
Merged via the queue into esp-rs:main with commit 02d221e Sep 23, 2024
28 checks passed
@bugadani bugadani deleted the twai branch September 23, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants