Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DmaDescriptor methods public #2237

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

Dominaezzz
Copy link
Collaborator

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

This makes all the private methods for manipulating the DmaDescriptors public.
The motivation for this is to allow users provide custom implementations of DmaTxBuffer and DmaRxBuffer.

Testing

It builds

@Dominaezzz Dominaezzz marked this pull request as ready for review September 26, 2024 11:02
esp-hal/src/dma/mod.rs Outdated Show resolved Hide resolved
esp-hal/src/dma/mod.rs Outdated Show resolved Hide resolved
esp-hal/src/dma/mod.rs Outdated Show resolved Hide resolved
esp-hal/src/dma/mod.rs Outdated Show resolved Hide resolved
esp-hal/src/dma/mod.rs Outdated Show resolved Hide resolved
esp-hal/src/dma/mod.rs Outdated Show resolved Hide resolved
esp-hal/src/dma/mod.rs Show resolved Hide resolved
@bugadani
Copy link
Contributor

Besides the nits I have to pick w.r.t. the documentation, I think this is a valuable change. I would like to see a community crate taking advantage of this and alloc.

Copy link
Contributor

@bugadani bugadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjoernQ bjoernQ added this pull request to the merge queue Sep 26, 2024
Merged via the queue into esp-rs:main with commit 4377ec0 Sep 26, 2024
28 checks passed
@Dominaezzz Dominaezzz deleted the public_dma branch October 3, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants