-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to configure WDT
action
#2330
Conversation
2b6f955
to
0d965a9
Compare
Update: I've managed to resolve problems with |
eea8d8d
to
500e8a1
Compare
We discussed this in our triage meeting today. I think for the time being, we are okay with simply documenting the requirements for the bootloader; we'd like to continue investigating if we can bypass this step, however there's no reason not to move forward with this PR IMO. @playfulFence when you're able, could you please make sure the requirements for MWDT are clearly documented, and then get this PR ready for review/merge? |
500e8a1
to
f2203b6
Compare
f2203b6
to
f238b84
Compare
f238b84
to
c034b69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
While we can't test the reset functionality we could probably have HIL tests to test the interrupt - but maybe in a follow-up PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM! (Other than the broken imports 😁 )
6fe0241
to
650f47c
Compare
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
close #1831
Also made some small improvements in code quality, aligned mode names with the official Espressif documentation
Currently, setting up MWDT stages is only possible with custom bootloader. Also, I think we should document the whole process of creating a custom bootloader and using it with our driver (I've opened an issue for this: esp-rs/book#170)
Testing
Used implemented function in example.