Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to configure WDT action #2330

Merged
merged 10 commits into from
Oct 30, 2024

Conversation

playfulFence
Copy link
Contributor

@playfulFence playfulFence commented Oct 10, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

close #1831

Also made some small improvements in code quality, aligned mode names with the official Espressif documentation

Currently, setting up MWDT stages is only possible with custom bootloader. Also, I think we should document the whole process of creating a custom bootloader and using it with our driver (I've opened an issue for this: esp-rs/book#170)

Testing

Used implemented function in example.

@playfulFence
Copy link
Contributor Author

Update: I've managed to resolve problems with MWDT, it was about bootloader settings.
It turns out we need to disable TASK_WDT and INT_WDT to make MWDT work "predictable".
I'm working on a proper solution of how to implement it in our driver in a less painful way...

@playfulFence playfulFence force-pushed the feature/wdt_api branch 2 times, most recently from eea8d8d to 500e8a1 Compare October 21, 2024 07:58
@jessebraham
Copy link
Member

We discussed this in our triage meeting today. I think for the time being, we are okay with simply documenting the requirements for the bootloader; we'd like to continue investigating if we can bypass this step, however there's no reason not to move forward with this PR IMO.

@playfulFence when you're able, could you please make sure the requirements for MWDT are clearly documented, and then get this PR ready for review/merge?

@playfulFence playfulFence removed the status:blocked Unable to progress - dependent on another task label Oct 29, 2024
@playfulFence playfulFence marked this pull request as ready for review October 29, 2024 11:09
esp-hal/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ
Copy link
Contributor

bjoernQ commented Oct 30, 2024

While we can't test the reset functionality we could probably have HIL tests to test the interrupt - but maybe in a follow-up PR

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! (Other than the broken imports 😁 )

@jessebraham jessebraham added this pull request to the merge queue Oct 30, 2024
Merged via the queue into esp-rs:main with commit 3e42b76 Oct 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is currently no way to configure WDT to do anything but a system reset
4 participants