SPI type erasure #2334
Merged
SPI type erasure #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
utils
branch
2 times, most recently
from
65aa39b to
9414b09
Compare
MabezDev
reviewed
Oct 18, 2024
Dominaezzz
reviewed
Oct 18, 2024
Dominaezzz
reviewed
Oct 18, 2024
MabezDev
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Very excited to have this land! This PR LGTM, two notes though:
- We should try and reorder (and maybe erase) every driver that has an instance to get that done in this release to avoid inconsistencies
- We should add a note in the API-GUIDELINES (don't worry, not in this PR but I'll add to the boiler plate tracking issue) about the param ordering so that we put the instance last so we can do this trick.
MabezDev
reviewed
Oct 21, 2024
JurajSadel
reviewed
Oct 21, 2024
| @@ -38,8 +38,8 @@ crate::peripherals! { | |||
| HINF <= HINF, | |||
| I2C0 <= I2C0, | |||
| I2C1 <= I2C1, | |||
| I2S0 <= I2S0 (I2S0), | |||
| I2S1 <= I2S1 (I2S1), | |||
| [I2s0] I2S0 <= I2S0 (I2S0), | |||
There was a problem hiding this comment.
Could you please elaborate what does this mean?
There was a problem hiding this comment.
Added a doc comment for the peripherals macro
jessebraham
reviewed
Oct 21, 2024
jessebraham
reviewed
Oct 21, 2024
jessebraham
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Changes also include #2335