Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add burst transfer support to DMA buffers #2336

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

Dominaezzz
Copy link
Collaborator

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Adds a is_burstable to Preparation, allowing DMA buffer implementations to declare whether they conform to the alignment required for burst transfers.

Testing

HIL tests

@Dominaezzz Dominaezzz mentioned this pull request Oct 10, 2024
20 tasks
@bugadani bugadani added this pull request to the merge queue Oct 16, 2024
Merged via the queue into esp-rs:main with commit 6e2606b Oct 16, 2024
28 checks passed
@Dominaezzz Dominaezzz deleted the burst_support branch October 16, 2024 21:39
@bugadani
Copy link
Contributor

Is a reason to manually disable burst mode? If a particular transfer is "burstable", shouldn't we try to enable burst mode automatically? Right now we keep it disabled by default, and waste 2 bools per DMA channel to track whether burst mode is enabled, and I'm wondering if this is necessary at all.

@Dominaezzz
Copy link
Collaborator Author

The only reason I can think of is bandwidth. I unfortunately don't know enough about the hardware to say if there's no consequences for having 8 burst transfers going at the same time.

Though if there are no consequences then why do DMA channels have priorities. I just chose not to assume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants