-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement a parallel interface for esp32 using the i2s peripheral #2348
Conversation
ed9b4bc
to
498d12a
Compare
Not sure why the |
They've always been flakey. |
80d61f9
to
1c86951
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I was only able to test this with a logic-analyzer but that looked good
I'm hoping we can get away with minimal changes for the S2 - the TRM seems to mention LCD there as well. Thank you! |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
The
ESP32
supports a "LCD" interface on the i2s peripheral. This PR implements that for TX. Note that there are some limitations on the byte/word order that I don't believe can be corrected with peripheral configuration:Testing